Some bugfixes (upscaling, preanimation, webp on char buttons, viewport layout) #202
Conversation
By default it used to make all images pixelated.
Fix for: Empty messages don't play the preanimation AttorneyOnline#191
Fix: background scaling AttorneyOnline#92 Changes: Now every image on the viewport is centered in the X and Y.
webAO/styles/client.css
Outdated
| top: 0; | ||
| left: 0; | ||
| top: 50%; | ||
| left: 50%; | ||
| transform: translate(-50%, -50%); | ||
| } | ||
|
|
||
| #client_court { | ||
| position: absolute; | ||
| height: 100%; | ||
| top: 0; |
There was a problem hiding this comment.
please remove the old top
webAO/styles/client.css
Outdated
| } | ||
|
|
||
| #client_court { | ||
| position: absolute; | ||
| height: 100%; | ||
| top: 0; | ||
| left: 0; | ||
| top: 50%; | ||
| left: 50%; | ||
| transform: translate(-50%, -50%); |
There was a problem hiding this comment.
this is a known trick to center stuff in css but it doesn't work in all situations, need to test this
| @@ -311,17 +325,20 @@ | |||
|
|
|||
| .client_bench { | |||
| position: absolute; | |||
| height: auto; | |||
| width: 100%; | |||
| height: 100%; | |||
There was a problem hiding this comment.
some benches are only a picture of the bench and this way they would stretch the entire height of the viewport and block it
|
i'm willing to go for it with the benches, people should keep their content up to date |
|
Should be ready now, I think. |
|
Did this fix #92 completely or partially? |
Is partially fixed @OmniTroid. See below for more details Bugs as of now:Now the image of the character is centered:
But the background and desk isn't centered at all on 16:9:
Compared to AO2 (16:9 judge):
4:3 (works fine)
16:9
16:9 (on AO2):
4:3 (witness)
16:9 (witness)
16:9 (AO2 - witness)
4:3 (Prosecution)
16:9 (Prosecution)
16:9 (AO2 - Prosecution)
Expected behaviour (coming from AO2 client):
For it to not have blank space on the sides, content creators would need to fill it (make the background and desk with 16:9 aspect ratio in mind). If anyone asks the default aspect ratio is 4:3 as of now, making #180 solved (idk when it got resolved). |
|
Thanks for the detailed breakdown. Would be great to have this in issue #92 |
This fixes:
Changes:
Current state:
Stable