Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added makeup gain and dry wet mix to DynamicRangeCompressor #33

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Matt54
Copy link
Member

@Matt54 Matt54 commented Jul 26, 2024

This introduces dedicated gain and dry/wet mix controls for the DynamicRangeCompressor:

  • Gain Control: The current compressor only reduces the signal level. In audio applications, it's common to apply makeup gain to compensate for this reduction, bringing the overall signal level back up.
  • Dry/Wet Mix Control: This allows for convenient parallel compression, blending the processed (compressed) signal with the unprocessed (dry) signal.

Processing Logic:

  • Makeup Gain: Applied only to the processed (compressed) signal.
  • Dry/Wet Mix: Computed after the makeup gain is applied.

@Matt54 Matt54 requested review from aure and wtholliday as code owners July 26, 2024 13:18
Copy link
Member

@aure aure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's bad that this kind of change can be added without breaking some test, but that's on us to improve the tests.

@aure
Copy link
Member

aure commented Jul 27, 2024

Looks like a bunch of tests are borked, will likely merge and deal with that after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants