Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dry wet to distortion #34

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Conversation

Matt54
Copy link
Member

@Matt54 Matt54 commented Jul 30, 2024

This introduces dedicated dry/wet mix control for TanhDistortion. This allows for convenient parallel distortion - blending the processed (distorted) signal with the unprocessed (dry) signal.

Processing Logic:

Post Gain: Applied only to the processed (distorted) signal.
Dry/Wet Mix: Computed after the post gain is applied to distorted signal.

@Matt54 Matt54 requested review from aure and wtholliday as code owners July 30, 2024 21:41
Copy link
Member

@aure aure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It bugs me a little that these changes don't require new tests, and the tests are not in a passing state anyway, so I'll approve this and see about the tests later.

@aure aure merged commit 792fbf8 into AudioKit:main Jul 30, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants