Remove randomness from AstroDB.create_unique_table_name
#39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Comment table names will now 'roll forward' as new ones are created
- Restricted names to 3 characters, allowing for 26^3 (17576) possible names
- Removed unused AstroDB.comment_table_exists method and associated test
- Modified the existing test for AstroDB.create_unique_table_name to account for new functionality
- Added 2 mock classes in the new tests/astro_mocks.py file
- MockSqlite3Connection
- MockSqlite3Cursor
- Added a fixture mock_sqlite3_connect to utilize the above mock classes to mock the database
- I should now have full control over the database with this fixture
- Modify tests to account for new error handling - Add fixture to mock database returning None to simulate record not found - Add static method YouTubeDataAPI.valid_video_id to aid in error checking
AustinCullar
deleted the
32-remove-randomness-from-astrodbcreate_unique_table_name
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will remove the randomness from
AstroDB.create_unique_name. The new method for generating unique names involves the manipulation of a 3 character string consisting of capital letters.The first table name will be named
AAA. For each additional table, the name will be 'rolled forward' such that:This will provide
26^3(17576) possible names. It is unlikely for this limit to present a problem, since that would imply we have over 17k YouTube videos' worth of data in our database.Additional work in this change:
tests/astro_mocks.py file