Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove randomness from AstroDB.create_unique_table_name #39

Merged

Commits on Oct 1, 2024

  1. - Remove randomness AstroDB.create_unique_table_name

        - Comment table names will now 'roll forward' as new ones are created
        - Restricted names to 3 characters, allowing for 26^3 (17576) possible names
    - Removed unused AstroDB.comment_table_exists method and associated test
    - Modified the existing test for AstroDB.create_unique_table_name to account for new functionality
        - Added 2 mock classes in the new tests/astro_mocks.py file
            - MockSqlite3Connection
            - MockSqlite3Cursor
        - Added a fixture mock_sqlite3_connect to utilize the above mock classes to mock the database
            - I should now have full control over the database with this fixture
    AustinCullar committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    d45d246 View commit details
    Browse the repository at this point in the history
  2. - Fix linting error

    AustinCullar committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    f6ff862 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. - Add error handling to astro_db methods

    - Modify tests to account for new error handling
    - Add fixture to mock database returning None to simulate record not found
    - Add static method YouTubeDataAPI.valid_video_id to aid in error checking
    AustinCullar committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    9e6aea2 View commit details
    Browse the repository at this point in the history
  2. - Fix linting errors

    AustinCullar committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    f373d3a View commit details
    Browse the repository at this point in the history