Add FileHandler for logging to file, new argument for logging API JSON responses to file
#59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `--log-json`: log json to file, not console
- `--log-file`: optional argument to specify location of log file
- by default, this will be `astro_log.txt` in the current directory
- Add contextmanager method to AstroLogger() to facilitate logging only to file
- this is used to capture json responses, since these are very noisy
- AstroLogger.print_object() has been replaced with print_video_data()
- Trying to move away from rich tables, as these are not printed to log file
- logging tests modified to account for log method changes
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two new arguments are added here:
--log-json | -j: log JSON responses from API to the log file only--log-file: specify name/location of log file (./astro_log.txtby default)Other changes: