Automate Release (Core) #2574
Merged
Automate Release (Core) #2574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8ae6bc4.
fjorgemota
reviewed
Sep 19, 2023
.github/workflows/create-release.yml
Outdated
| node scripts/create-release.mjs wp-job-manager ${{ github.event.number }} | ||
| unzip -q wp-job-manager.zip | ||
| - name: Deploy to WordPress.org | ||
| uses: 10up/action-wordpress-plugin-deploy@stable |
There was a problem hiding this comment.
I think it would be cool to use a fork inside the Automattic org for this.
Just to avoid possible security issues.
There was a problem hiding this comment.
10up is a pretty reputable company and an Automattic partner, so I think it should be safe enough / not worth maintaining a fork.
There was a problem hiding this comment.
Is @stable the latest version? Would it be possible to at least use a specific version?
There was a problem hiding this comment.
Pinned this down to a commit hash in e1cf715
gikaragia
reviewed
Sep 28, 2023
| console.log( `-----------------------------` ); | ||
| console.log( `Pull requests to include (milestone ${ newVersion }):` ); | ||
|
|
||
| execSync( ghPrs, { stdio: 'inherit' } ); |
There was a problem hiding this comment.
Maybe I miss something but I think this doesn't do anything
There was a problem hiding this comment.
This one should just output the list of PRs directly to the console.
gikaragia
reviewed
Sep 28, 2023
gikaragia
approved these changes
Sep 28, 2023
gikaragia
reviewed
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
npm run release <version>commandrelease/*branch, that writes the final changelog entry, creates and tags a new release on GH, then deploys it to WordPress.orgTesting instructions
Usage docs
gh auth loginthe first time to set it up