Add/usage tracking improvements

[mikeyarce]

Fixes #2580

Changes proposed in this Pull Request

• Usage tracking checkbox in Setup is now checked by default
• The "Usage Tracking" notice will show up 1 week after the plugin has been activated
• When the plugin is updated, we'll show the "Usage Tracking" notice again, but only one time. If it's dismissed, it won't show up on future updates
• I also added a few target="_blank" attributes to some links that did not have them.

Testing instructions

• Pull this branch to a test site
• Make sure you DON'T have usage tracking enabled
• Go to run a setup on this page: /wp-admin/index.php?page=job-manager-setup
• See that the box is checked by default
• Click Save and Skip setup and make sure the option is saved properly

---

• To mimic the 1 week wait, you can edit the time in delay_tracking_notice to display the notice.
• To mimic a plugin update, you can edit the WP_Job_manager::updater() function so that the condition is true and so that the code runs
• Make sure that the usage tracking prompt shows up after that.

[gikaragia]

I don't understand why we don't do this in PHP directly. Changed that in 00ba0f0

@mikeyarce let me know if there is something that I'm missing here.

[gikaragia]

I think that creating a function that has a single statement makes code a bit harder to read, especially when this function is called only once. You can argue that sometimes when a single statement is very complicated, it makes it easier to understand it if you give it a name with a function but I don't think this is the case here.

[gikaragia]

Transients should be thought of as a cache that can be deleted any time. In our case this won't be a big issue but I think that having an option for that will be better.

[gikaragia]

Since you are on Support Rotation this week Mikey, I'll pick up the changes for this PR. I just left the comments for documentation purposes.

[gikaragia]

WP defines a few useful constants for these:

	define( 'MINUTE_IN_SECONDS', 60 );
	define( 'HOUR_IN_SECONDS', 60 * MINUTE_IN_SECONDS );
	define( 'DAY_IN_SECONDS', 24 * HOUR_IN_SECONDS );
	define( 'WEEK_IN_SECONDS', 7 * DAY_IN_SECONDS );
	define( 'MONTH_IN_SECONDS', 30 * DAY_IN_SECONDS );
	define( 'YEAR_IN_SECONDS', 365 * DAY_IN_SECONDS );

[gikaragia]

Hey @fjorgemota since the rest of the team is in support rotation, can you take a look at these changes? The testing instructions should be updated as:

• To simulate a week passing you can update job_manager_display_usage_tracking_once to a small number.
• To simulate a new plugin installation, you can delete wp_job_manager_version.
• Any changes happen on plugin activation so to test you should: 1) Deactivate WPJM 2) Do any changes to the db 3) Re-enable the plugin.

[fjorgemota]

This is looking generally good. I'll test it further tomorrow.

From what I'm seeing, when I deactivate and then activate, the notice looks to be appearing even when the option job_manager_display_usage_tracking_once is in the future (with value 1696893421), after removing the option wp_job_manager_version. I'm not sure if I'm doing something wrong, but I'll test more tomorrow.

[gikaragia]

the notice looks to be appearing even when the option job_manager_display_usage_tracking_once is in the future

Well spotted! The logic was flawed, fixed in cc81563

[fjorgemota]

Wow! Thanks a lot for making these changes.

I reviewed them all and now the feature works properly. Also tried updating the option job_manager_display_usage_tracking_once to a value generated by strtotime('+1 minute'); and I could confirm that now the feature works beautifully.

Also, the linting changes look great.

Thanks a lot! Approved!

(I still left two very minor comments with suggestions, but I believe you can consider the PR as approved after the changes)

[gikaragia]

There are some issues unrelated to this PR. I'll go ahead with merging this one and fix them as part of a separate PR