Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forms: Fix dropdown icon position #41074

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Forms: Fix dropdown icon position #41074

wants to merge 2 commits into from
+10 −2

Conversation

edanzer
Copy link
Contributor

@edanzer edanzer commented Jan 15, 2025 •
edited
Loading

Fixes #41060

Proposed changes:

When viewing a form block dropdown field on the frontend, the arrow icon initially loads in the in the wrong place - in the lower right. It then corrects after couple seconds but the delay is very noticeable and jarring. The delay occurs because the position styling is based on calculations using CSS variables that are, in turn, set via JavaScript after page load here.

This PR replaces the CSS vars and calculations for simpler positioning rules.

I tested across five themes, and the difference in styling and position for the icon is marginal.

Initial Load Before (ignore the shading - just the position of the arrow)
dropdown arrow

Initial Load After
dropdown-icon-after

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Add a Jetpack Form with a select dropdown and a few options.
  • Go to the frontend and confirm that dropdown arrow initially loads in roughly the right location.
  • Test across a few different themes.
  • Note that the icon may still shift a bit within the select field depending on theme, as the same dynamically-set CSS vars are used for a variety of form and input styles, including aspects of the select input.

@edanzer edanzer added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Contact Form [Block] Contact Form Form block (also see Contact Form label) labels Jan 15, 2025
@edanzer edanzer requested a review from a team January 15, 2025 02:34
@edanzer edanzer self-assigned this Jan 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 15, 2025 •
edited
Loading

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/forms-select-field-icon branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack fix/forms-select-field-icon

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Package] Forms [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Jan 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 15, 2025 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for February 4, 2025 (scheduled code freeze on undefined).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jan 15, 2025
edanzer
edanzer commented Jan 15, 2025
View reviewed changes
projects/plugins/jetpack/changelog/fix-forms-select-field-icon
Significance: patch
Type: bugfix

Forms: Fix dropdown icon style
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I need this second changelog item? First is for the forms package, this is for the Jetpack plugin.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'll end up getting Jetpack changelog in addition to package changelog if you answer "yes" to "should site owners know about this change?"

You can delete it, but really no biggie to just have it too.

simison
simison approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@simison simison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I tried breaking it with some wild styles:

Screenshot 2025-01-15 at 11 24 41

I noticed the carret is different size in editor vs fontend when choosing bigger text size for field, but that's separate problem from this PR.

Screenshot 2025-01-15 at 11 24 33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simison simison simison approved these changes

Assignees

@edanzer edanzer

Labels
[Block] Contact Form Form block (also see Contact Form label) [Feature] Contact Form [Package] Forms [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Forms: Select dropdown arrow initial loads in wrong place
2 participants
@edanzer @simison