fix: make sure carousels without images aren't collapsed

[laurelfulford]

All Submissions:

• Have you followed the Newspack Contributing guideline?
• Does your code follow the WordPress' coding standards and VIP Go coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

This PR fixes an issue where the Post Carousel slider would be collapsed on the front-end if none of the posts had featured images.

See 1200550061930446-as-1204845439898529

How to test the changes in this Pull Request:

1. Add a post carousel to the editor and change the setting so none of the posts have featured images (this could be adjusting the query, or quickly spinning up 3+ posts without featured images.
2. View on the front-end; note you have the little pagination at the bottom, and nothing more:

3. Apply the PR and run npm run build.
4. Confirm your carousel now shows on the front-end.

5. Test a couple different aspect ratio options and confirm the placeholders fill the space on the front-end.

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully ran tests with your changes locally?

[leogermani]

It works,

But in some cases, the navigation arrow is over the author avatar:

Not sure if that's avoidable (and yes, I've got a bunch of posts named "About us")

Also @laurelfulford , I remember us discussing what should be the behavior of the carousel when none of the posts had images... I think the carouse wasn't being displayed at all.. and we changed that... Do you remember that?

[matticbot]

🎉 This PR is included in version 1.74.0-alpha.2 🎉

The release is available on:

• npm package (@alpha dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[matticbot]

🎉 This PR is included in version 1.74.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[laurelfulford]

Sorry I'm getting back to this so late @leogermani!

Also @laurelfulford , I remember us discussing what should be the behavior of the carousel when none of the posts had images... I think the carouse wasn't being displayed at all.. and we changed that... Do you remember that?

Kind of! I did some digging around to confirm: it looks like the carousel was updated so it didn't show anything if none of the posts had images here. After we got reports of this being confusing, it was changed to allow posts without images again here.