Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(checkout-button): handle 10+ product variations #1536

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

miguelpeixe
Copy link
Member

@miguelpeixe miguelpeixe commented Sep 22, 2023

All Submissions:

Changes proposed in this Pull Request:

Increase the pagination limit while fetching product variations in the Checkout Button block and the overflow for the variation modal when users are allowed to select a variation before checkout.

How to test the changes in this Pull Request:

  1. While on the release branch, create a product with 20 variations
  2. Draft a new page and add a "Checkout Button" block
  3. Select the new product, uncheck the "Allow the reader to select the variation before checkout." option, and confirm the dropdown below only renders 10 variations
  4. Check the option again, save, visit the page, click the button, and confirm the variation list exceeds the container bounds
  5. Check out this branch, refresh the page, click the button, and confirm the variation modal renders a scrollbar
  6. Edit the page, uncheck the "Allow the reader to select the variation before checkout." option and confirm all variations render in the dropdown

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@miguelpeixe miguelpeixe merged commit 5df5065 into release Sep 26, 2023
9 checks passed
@miguelpeixe miguelpeixe deleted the hotfix/checkout-button-variation-paging branch September 26, 2023 12:43
matticbot pushed a commit that referenced this pull request Sep 28, 2023
## [1.75.1](v1.75.0...v1.75.1) (2023-09-28)

### Bug Fixes

* **checkout-button:** handle 10+ product variations ([#1536](#1536)) ([5df5065](5df5065))
* query for CAP terms ([#1535](#1535)) ([49406b9](49406b9))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.75.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants