Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal-checkout): support utm params #1540

Closed
wants to merge 2 commits into from

Conversation

miguelpeixe
Copy link
Member

@miguelpeixe miguelpeixe commented Sep 26, 2023

All Submissions:

Changes proposed in this Pull Request:

Ensures UTM parameters are passed as form inputs to the checkout modal.

How to test the changes in this Pull Request:

Further details and instructions at Automattic/newspack-plugin#2665

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link
Member

@adekbadek adekbadek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my testing, this is not necessary. The form fields are already added with Automattic/newspack-plugin#2665 and I can complete testing successfully following instructions in Automattic/newspack-plugin#2665 without the changes from this PR. What am I missing?

@miguelpeixe
Copy link
Member Author

You're right! The existing strategy picks up the URL and merges them to the other params for generating the checkout URL for redirection.

I kept digging into what inconsistency I was trying to fix with this and found an issue with the strategy from Automattic/newspack-plugin#2665. Here's a PR to fix that: Automattic/newspack-plugin#2671

@miguelpeixe miguelpeixe deleted the fix/modal-checkout-utm-params branch September 28, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants