Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reCAPTCHA v2 + v3 for RAS-ACC flows #1811

Merged
merged 5 commits into from
Aug 27, 2024
Merged

fix: reCAPTCHA v2 + v3 for RAS-ACC flows #1811

merged 5 commits into from
Aug 27, 2024

Conversation

dkoo
Copy link
Contributor

@dkoo dkoo commented Jul 27, 2024 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

Fixes for reCAPTCHA implementation in RAS-ACC modal checkout.

How to test the changes in this Pull Request:

See Automattic/newspack-plugin#3283

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@dkoo dkoo mentioned this pull request Jul 27, 2024
Merged
6 tasks
@dkoo dkoo self-assigned this Jul 27, 2024
@dkoo dkoo marked this pull request as ready for review July 27, 2024 00:31
@dkoo dkoo requested a review from a team as a code owner July 27, 2024 00:31
@dkoo dkoo changed the title Fix/recaptcha for ras acc fix: reCAPTCHA v2 + v3 for RAS-ACC flows Jul 27, 2024
chickenn00dle
chickenn00dle approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@chickenn00dle chickenn00dle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving pending changes in the main plugin PR for this.

src/modal-checkout/index.js Outdated Show resolved Hide resolved
chickenn00dle
chickenn00dle previously requested changes Aug 2, 2024
View reviewed changes
includes/class-modal-checkout.php Outdated Show resolved Hide resolved
@chickenn00dle chickenn00dle dismissed their stale review August 26, 2024 18:55

Taking over for Derrick

chickenn00dle pushed a commit to Automattic/newspack-plugin that referenced this pull request Aug 27, 2024
@dkoo
fix(ras-acc): reCAPTCHA v2 + v3 for RAS-ACC flows (#3283)
824e885 
This PR (along with Automattic/newspack-blocks#1811 and Automattic/newspack-newsletters#1581) fixes reCAPTCHA v2 and v3 integrations for RAS-ACC flows, which are currently broken in epic/ras-acc. It also implements some improvements and standardizations to the reCAPTCHA implementations
@chickenn00dle chickenn00dle merged commit 5b5f9e2 into epic/ras-acc Aug 27, 2024
8 checks passed
@chickenn00dle chickenn00dle deleted the fix/recaptcha-for-ras-acc branch August 27, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chickenn00dle chickenn00dle chickenn00dle approved these changes

Assignees

@dkoo dkoo

Labels
ras-acc testing [Status] Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkoo @chickenn00dle