Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ras-acc): update limited subscription cart error and modal layout #1858

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

chickenn00dle
Copy link
Contributor

@chickenn00dle chickenn00dle commented Aug 27, 2024

All Submissions:

Changes proposed in this Pull Request:

Closes https://app.asana.com/0/1207817176293825/1207878733150171/f

This PR updates the limited subscription checkout error message and adds a back button to the modal when an error is present:

Screenshot 2024-08-27 at 17 07 47

How to test the changes in this Pull Request:

  1. Set up a limited subscription product
  2. Add a checkout button for the limited subscription to any page or post
  3. As a reader that does not have a subscription for this product, purchase the limited subscription. Confirm you can checkout with no issues and there is no additional Go back button present in the checkout modal.
  4. As the same reader, attempt to purchase the limited subscription once more. Confirm an error appears in the modal and a Go back button is present as pictured above
  5. Confirm the Go back button closes the modal
  6. Repeat step 4 and this time confirm the X also closes the modal

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link
Contributor

@laurelfulford laurelfulford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Work as described, the 'Go Back' button is a nice touch!

Absolute non-blocking question: should these strings be included with the others that can be filtered?

@chickenn00dle
Copy link
Contributor Author

Absolute non-blocking question: should these strings be included with the others that can be filtered?

That's a good question. I don't think we are filtering any other RAS errors so I didn't include this one. If we'd like to though, I think we can tackle that in another PR where maybe we make all reader facing RAS errors filterable?

@chickenn00dle chickenn00dle merged commit 184b06f into epic/ras-acc Aug 29, 2024
10 checks passed
@chickenn00dle chickenn00dle deleted the fix/update-cart-error-layout branch August 29, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants