Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ras-acc): add check to prevent JS error in variation modal #1862

Closed
wants to merge 1 commit into from

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

I noticed this randomly while testing another PR: the changes I made to keep modals open while redirecting broke the ability to close the variation modal.

How to test the changes in this Pull Request:

  1. On epic/ras-acc, set up a Checkout Button block with a variable product where the reader can pick the variation.
  2. On the front end, click the Checkout Button block to open the variation picker.
  3. Click the close button; note it doesn't close and throws a JS error.
  4. Apply this PR and run npm run build.
  5. Repeat steps 2-3 and confirm that the modal closes as expected.
  6. Repeat a couple of the tests from fix(ras-acc): don't close modal when redirecting #1855 and confirm that the modal-not-closing-when-redirecting behaviour still works as expected.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford
Copy link
Contributor Author

laurelfulford commented Aug 29, 2024

Closing; it looks like this is already fixed in #1861 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant