fix(ras-acc): performance enhancements and small fixes #1871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chickenn00dle
force-pushed
the
fix/performance-enchancements
branch
from
62a121f
to
aa8765f
Compare
chickenn00dle
force-pushed
the
fix/performance-enchancements
branch
from
aa8765f
to
c952baa
Compare
chickenn00dle
commented
Sep 5, 2024
| @@ -7,7 +7,7 @@ | |||
| * @return {void} | |||
| */ | |||
| export function domReady( callback ) { | |||
| if ( typeof document === 'undefined' ) { | |||
| if ( typeof document === 'undefined' || typeof callback !== 'function' ) { | |||
There was a problem hiding this comment.
Addresses a random browser error where callback was undefined in some circumstances.
chickenn00dle
commented
Sep 5, 2024
Comment on lines
+410
to
+413
| // Signal checkout registration. | ||
| form.appendChild( | ||
| createHiddenInput( newspackBlocksModal.checkout_registration_flag, '1' ) | ||
| ); |
There was a problem hiding this comment.
We only want this called whenever the auth modal is opened by checkout.
laurelfulford
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Looks good!
I tested this alongside Automattic/newspack-plugin#3391, so it included making purchases when already logged in and when I needed to sign up/sign in, and all worked well!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
This PR makes some small fixes and performance updates.
This PR was opened while digging into potential issues with RAS-ACC loading times. We found that the issue wasn't specific to RAS-ACC but wanted to push these changes up anyway.
How to test the changes in this Pull Request:
Other information: