Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ras-acc): ensure order review table is always unblocked when visible #1875

Merged

Conversation

chickenn00dle
Copy link
Contributor

@chickenn00dle chickenn00dle commented Sep 9, 2024

All Submissions:

Changes proposed in this Pull Request:

Closes https://app.asana.com/0/1207817176293825/1208232700780037/f

Modal checkout clones the Woo order review table and sticks it at the bottom of the modal whenever WC checkout updates. However, in some cases it's possible for Woo to block the form before our cloning takes place, resulting in a blocked order review table:

Screenshot 2024-09-09 at 13 52 54

This PR forces the cloned order review table to unblock prior to rendering it so this doesn't happen anymore:

Screenshot 2024-09-09 at 14 00 08

How to test the changes in this Pull Request:

  1. As an admin enable taxes or shipping and create a product that has these applied
  2. Add a checkout button block to any page or post for the product in step 1
  3. As a logged out reader, trigger modal checkout via the checkout button added in step 2
  4. Register an account, and proceed to the checkout modal
  5. Add billing details and select next
  6. In the payment method step, confirm the order review table is not blocked

Bonus: Smoke test the order review table in other scenarios, such as updating the price via NYP, adding a coupon, etc.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@chickenn00dle chickenn00dle marked this pull request as ready for review September 9, 2024 05:01
@chickenn00dle chickenn00dle requested a review from a team as a code owner September 9, 2024 05:01
@chickenn00dle chickenn00dle force-pushed the fix/update-checkout-on-checkout-modal-transition branch from 61cbd30 to 7c3fb7b Compare September 9, 2024 05:01
Copy link
Contributor

@laurelfulford laurelfulford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I tested a subscription product, a product needing shipping, plus NYP and coupon, plus the Donate block 👍

@chickenn00dle chickenn00dle merged commit d53a2fb into epic/ras-acc Sep 9, 2024
10 checks passed
@chickenn00dle chickenn00dle deleted the fix/update-checkout-on-checkout-modal-transition branch September 9, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants