Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (ras-acc): add styles for terms and conditions #1880

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This PR adds some styles for WooCommerce's built in terms and conditions checkbox, which appears on the second screen of the modal checkout.

See: 1207817176293825-as-1208279455320432

How to test the changes in this Pull Request:

  1. Create a page and title it "Terms and Conditions" or something similar. Give it some text content.
  2. Under WP Admin > WooCommerce > Advanced, under the Page Settings header, use the Terms and conditions dropdown to find your page:

CleanShot 2024-09-11 at 18 42 26

  1. Run through a checkout; note the appearance of the Terms and Conditions checkbox at the bottom of the second screen.

CleanShot 2024-09-11 at 18 45 34

  1. Click the Terms and Conditions text to open the terms details and note the appearance.

CleanShot 2024-09-11 at 18 46 05

  1. Apply this PR and run npm run build.
  2. Repeat steps 3 and 4 and confirm that the Terms checkbox and details look better:

CleanShot 2024-09-11 at 18 44 18

CleanShot 2024-09-11 at 18 44 34

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford
Copy link
Contributor Author

@kevinzweerink gave a thumbs up in the Asana task, so I'm going to remove the Needs Design Review label.

@laurelfulford
Copy link
Contributor Author

Thanks @adekbadek!

@laurelfulford laurelfulford merged commit 35b2585 into epic/ras-acc Sep 13, 2024
11 checks passed
@laurelfulford laurelfulford deleted the fix/terms-and-conditions branch September 13, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants