Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ras-acc): respect cart coupons on nyp submit #1885

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

chickenn00dle
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Closes https://app.asana.com/0/1207817176293825/1208344897866336/f

This PR fixes an issue where the checkout button nyp input would remove any applied coupons on submit.

Screenshot 2024-09-18 at 16 36 53

How to test the changes in this Pull Request:

  1. Set up a checkout button block for a product that has both coupons AND nyp enabled
  2. As a reader trigger the checkout modal via the checkout button and go through checkout until you get to the payment method section
  3. Input a valid coupon and submit. Verify the order review table and submit button update with the correct values
  4. Now input a valid NYP amount and submit. On epic/ras-acc the coupon will be removed. On this branch, it should not and everything should update correctly.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link
Contributor

@laurelfulford laurelfulford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find! This fixes the issue! 🙌

@chickenn00dle chickenn00dle merged commit f5f744e into epic/ras-acc Sep 19, 2024
10 checks passed
@chickenn00dle chickenn00dle deleted the fix/respect-coupons-on-nyp-submit branch September 19, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants