-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(modal-checkout): optimize iframe load and refactor anonymous cart generation #1896
Merged
Merged
Changes from 7 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
e48e12c
fix(modal-checkout): optimize iframe load
miguelpeixe f3f6992
fix: prevent multiple runners
miguelpeixe f0972b7
fix: allow `newspack-newsletters-` scripts
miguelpeixe abb28ac
fix: call cb on early return and log missing jquery
miguelpeixe 07f5df3
chore: log when unable to block form
miguelpeixe f55c4bb
fix: fix iframe ready check and remove ie8 support
miguelpeixe 25f6118
fix: remove `init_checkout` listener
miguelpeixe 7dcfc12
fix: immediately invoked function
miguelpeixe 7929abe
Merge branch 'epic/ras-acc' into fix/optimize-modal-checkout-load
miguelpeixe 7b3ccd9
Merge branch 'epic/ras-acc' into fix/optimize-modal-checkout-load
miguelpeixe 27d3bc4
feat: add to cart async with the auth flow
miguelpeixe 12b8f26
chore: lint
miguelpeixe 3cfbf80
fix: refactor anonymous cart handling
miguelpeixe 047850d
fix: update method names
miguelpeixe 893a9c4
feat: filter allowed assets
miguelpeixe 35b6d59
fix: restore `is_newspack_donate` and use guard clause
miguelpeixe 6a68ca6
fix: variable position
miguelpeixe 50f0e68
fix: isolate checkout registration flag
miguelpeixe 68c787c
chore: remove extra line
miguelpeixe af02c11
fix: use url query param for checkout registration flag
miguelpeixe bffe929
chore: improve docblock
miguelpeixe 21f542c
fix: restore checkout url params functionality
miguelpeixe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its not uncommon for woo extensions to utilize these prefixes for scripts, so we probably wouldn't be fully covered. That said this is definitely a more thorough approach and better than what we have now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we talked about making this filterable so that publishers can have other payment gateways if they'd like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right! Thank you for reminding me, updated in 893a9c4