Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/hyperallergic empty cart modal checkout #1902

Merged

Conversation

chickenn00dle
Copy link
Contributor

@chickenn00dle chickenn00dle commented Oct 10, 2024

All Submissions:

Changes proposed in this Pull Request:

Small fixes for the changes in #1893

How to test the changes in this Pull Request:

See testing steps for #1893

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@chickenn00dle chickenn00dle marked this pull request as ready for review October 10, 2024 21:02
@chickenn00dle chickenn00dle requested a review from a team as a code owner October 10, 2024 21:02
@chickenn00dle
Copy link
Contributor Author

Sorry @miguelpeixe, thanks to @laurelfulford's digging I realized is_wc_endpoint_url doesn't actually check for the main WC cart and checkout page so had to make another change: b2b1786

Rerequesting review.

@chickenn00dle chickenn00dle merged commit dd46fcb into epic/ras-acc Oct 11, 2024
9 checks passed
@chickenn00dle chickenn00dle deleted the fix/hyperallergic-empty-cart-modal-checkout branch October 11, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants