Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecate video playlist block #1903

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

dkoo
Copy link
Contributor

@dkoo dkoo commented Oct 11, 2024

All Submissions:

Changes proposed in this Pull Request:

Deprecates the YouTube Video Playlist block, as this functionality is now a core feature of YouTube itself.

If the block already exists in any site content, the block will continue to render on the front-end, but editor instances will no longer be editable and will display a deprecation warning.

If the block doesn't exist in any site content, it won't be registered and therefore can't be added to any post content.

At a future date, we can consider removing all block assets from this repo.

How to test the changes in this Pull Request:

  1. On trunk, add some YouTube video embeds to post content. Make sure to embed using full, unshortened YouTube URLs to embed or they won't be recognized by the Video Playlist block.
  2. Add a YouTube Video Playlist block to another post or page. Confirm that it renders a preview in the editor and renders videos on the front-end.
  3. Check out this branch. Confirm that the block continues to render without changes on the front-end.
  4. Confirm that in the editor, the block shows a deprecation warning both in the block preview and in the sidebar, and that there's no longer UI to edit block attributes. Confirm that the links in the warning message link out to Google help docs explaining how to create/manage and embed YouTube playlists.
Screenshot 2024-10-11 at 4 47 09 PM
  1. Remove the YouTube Video Playlist block from the post (and any other posts/pages it might exist in*), save, then refresh the editor. Confirm that the YouTube Video Playlist block can no longer be found in the block inserter.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@dkoo dkoo self-assigned this Oct 11, 2024
@dkoo dkoo requested a review from a team as a code owner October 11, 2024 23:07
@dkoo dkoo merged commit 4876de6 into trunk Oct 14, 2024
9 checks passed
@dkoo dkoo deleted the fix/deprecate-video-playlist branch October 14, 2024 17:34
matticbot pushed a commit that referenced this pull request Oct 14, 2024
## [4.2.3-alpha.1](v4.2.2...v4.2.3-alpha.1) (2024-10-14)

### Bug Fixes

* articles block fail to get all inner blocks ([#1878](#1878)) ([c699724](c699724))
* deprecate video playlist block ([#1903](#1903)) ([4876de6](4876de6))
* potential fatal with invalid attribute combo ([#1900](#1900)) ([adf2e9d](adf2e9d))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 4.2.3-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants