Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add select2 to whitelisted scripts #1909

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This PR adds Select2 to the allowed scripts in the modal checkout.

How to test the changes in this Pull Request:

  1. Run through a modal checkout with a physical product.
  2. Note the appearance of the country/state dropdowns:

CleanShot 2024-10-18 at 09 07 53

  1. Apply this PR.
  2. Confirm that the dropdowns are styled correctly:

CleanShot 2024-10-18 at 09 08 23

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@miguelpeixe
Copy link
Member

Thank you for fixing that!

@laurelfulford
Copy link
Contributor Author

Thanks for the review! 🎉

@laurelfulford laurelfulford merged commit c9bd674 into epic/ras-acc Oct 18, 2024
10 checks passed
@laurelfulford laurelfulford deleted the fix/readd-select2 branch October 18, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants