Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Constant Contact error handling #1022

Open
miguelpeixe opened this issue Nov 16, 2022 · 2 comments
Open

Improve Constant Contact error handling #1022

miguelpeixe opened this issue Nov 16, 2022 · 2 comments
Assignees

Comments

@miguelpeixe
Copy link
Member

The ESP methods throw exceptions. These should be replaced with WP_Error() as it's the expected error handling already used for other providers.

@miguelpeixe miguelpeixe self-assigned this Nov 16, 2022
@leogermani
Copy link
Contributor

Maybe related to that, if you save CC as the provider without credentials, the site throws errors and the settings page becomes unusable

@leogermani
Copy link
Contributor

Also, we could have only one instance of the SDK in the main provider class instead of creating an instance in every method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants