fix(auth): simplify pending checkout

[miguelpeixe]

All Submissions:

• Have you followed the Newspack Contributing guideline?
• Does your code follow the WordPress' coding standards and VIP Go coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Automattic/newspack-blocks#1896 changes how the cart generation is handled for anonymous sessions. The cart is expected to be added to the session before authentication, allowing for this logic to be simplified.

The only stored value should now be the redirect URL so the checkout state can be recovered on ?checkout=1.

How to test the changes in this Pull Request:

Read more at Automattic/newspack-blocks#1896

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully ran tests with your changes locally?

[chickenn00dle]

Looks good for the most part. But FYI, we were using the isPendingCheckout method here as well to flag that content gated content shouldn't be reloaded during checkout:

newspack-plugin/includes/plugins/wc-memberships/class-memberships.php

Line 773 in bfab5b7

if ( ev.detail.authenticated && ! window?.newspackReaderActivation?.isPendingCheckout() ) {

This will need to be updated.

[miguelpeixe]

Thank you for catching that! Updated in 0945424

[chickenn00dle]

Great! Thanks for the update. Looks good!