Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrates SimplenoteEndpoints Swift Package #1199

Merged
merged 5 commits into from
Jul 26, 2024
Merged

Integrates SimplenoteEndpoints Swift Package #1199

merged 5 commits into from
Jul 26, 2024

Conversation

jleandroperez
Copy link
Contributor

@jleandroperez jleandroperez commented Jul 25, 2024 •
edited by charliescheer
Loading

Fix

In this PR we're wiring the new SimplenoteEndpoints SPM, and deleting the deleted code.

Test

  • Verify you can Sign Up for a new account
  • Verify you can Log In with a Code
  • Verify you can Log In by clicking the Login Email Link
  • Verify you can Log In with Password
  • Verify you can Delete your Account

If time allows please compare the files moved over to https://github.com/Automattic/SimplenoteEndpoints-Swift, and verify the changes performed there make sense.

Release

These changes do not require release notes.

@jleandroperez jleandroperez added debt Technical debt. [feature] security Anything relating to security, passcode lock, etc. labels Jul 25, 2024
@jleandroperez jleandroperez self-assigned this Jul 25, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Jul 25, 2024 •
edited
Loading

1 Warning
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@jleandroperez jleandroperez changed the title [WIP] Integrates SimplenoteEndpoints Swift Package Integrates SimplenoteEndpoints Swift Package Jul 25, 2024
@jleandroperez jleandroperez added this to the 2.21 milestone Jul 25, 2024
@jleandroperez jleandroperez marked this pull request as ready for review July 25, 2024 18:47
charliescheer
charliescheer approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@charliescheer charliescheer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jleandroperez
Copy link
Contributor Author

Thank you Charlie!!

@jleandroperez jleandroperez merged commit 4138485 into feature/1187-magic-links Jul 26, 2024
8 checks passed
@jleandroperez jleandroperez deleted the lantean/wiring-simplenote-endpoints-spm branch July 26, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliescheer charliescheer charliescheer approved these changes

@roundhill roundhill Awaiting requested review from roundhill

Assignees

@jleandroperez jleandroperez

Labels
debt Technical debt. [feature] security Anything relating to security, passcode lock, etc.
Projects
None yet
Milestone
2.21 ❄️
Development

Successfully merging this pull request may close these issues.
3 participants
@jleandroperez @dangermattic @charliescheer