Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magic Links: Limit the code input text field on login to 6 chars #1209

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

charliescheer
Copy link
Contributor

Fix

We recently implemented code authentication into Simplenote. One thing we were concerned about is what would happen if someone put in a huge amount of characters into the code field input. Nothing should happen, but it seemed like a good idea to limit the character count to on the code input text field.

So in this PR I have done just that

Test

(Required) List the steps to test the behavior. For example:

  1. Fresh install Simplenote. Go to login and enter your email
  2. when the code input appears, attempt to put in more characters than the code limit of 6
  • Confirm you can only put 6 characters in the code field
  • Confirm that the username and password fields do not have a limit in them

Review

(Required) Add instructions for reviewers. For example:

Only one developer is required to review these changes, but anyone can perform the review.

Release

(Required) Add a concise statement to RELEASE-NOTES.txt if the changes should be included in release notes. Include details about updating the notes in this section. For example:

These changes do not require release notes.

@charliescheer charliescheer added the [feature] login Anything relating to login label Jul 31, 2024
@charliescheer charliescheer added this to the Future milestone Jul 31, 2024
@charliescheer charliescheer self-assigned this Jul 31, 2024
Copy link
Contributor

@jleandroperez jleandroperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@charliescheer charliescheer merged commit 5ebddf2 into trunk Aug 12, 2024
8 checks passed
@charliescheer charliescheer deleted the charlie/code-login-field-char-limit branch August 12, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[feature] login Anything relating to login
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants