Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Translations #1211

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Conversation

jleandroperez
Copy link
Contributor

Fix

In this PR we're updating the Localizations. For the record:

  1. I've edited fastlane/Fastfile and commented out L262, L265 and L267
  2. Executed bundle exec fastlane finalize_release

@mokagio Would it be possible to confirm if doing this was required, or it's just part of the regular release process?
I think it wasn't really needed? (exactly the same as iOS!)

Thanks in advance!!

Test

  • Smoke test Simplenote and make sure everything looks good!

Release

These changes do not require release notes.

@jleandroperez jleandroperez added the i18n All things Internationalization. label Aug 13, 2024
@jleandroperez jleandroperez added this to the 2.21 ❄️ milestone Aug 13, 2024
@jleandroperez jleandroperez self-assigned this Aug 13, 2024
@jleandroperez jleandroperez marked this pull request as ready for review August 13, 2024 18:28
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@jleandroperez
Copy link
Contributor Author

Thank you!

@jleandroperez jleandroperez merged commit 382a161 into release/2.21 Aug 14, 2024
11 of 12 checks passed
@jleandroperez jleandroperez deleted the lantean/updates-localizations branch August 14, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n All things Internationalization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants