Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ecommerce trial plan allows installing dotorg themes #94541

Closed
dsas opened this issue Sep 13, 2024 · 1 comment
Closed

Ecommerce trial plan allows installing dotorg themes #94541

dsas opened this issue Sep 13, 2024 · 1 comment
Assignees
Labels
[Feature] Theme Showcase The theme showcase screen in Calypso in Appearance > Themes. [Pri] High [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Bug

Comments

@dsas
Copy link
Contributor

dsas commented Sep 13, 2024

Quick summary

It's possible to install a dotorg theme when using the ecommerce trial plan. However according to the WPCom_Features system, this isn't allowed fbhepr%2Skers%2Sjcpbz%2Sjc%2Qpbagrag%2Szh%2Qcyhtvaf%2Sjcpbz%2Qsrngherf%2Spynff%2Qjcpbz%2Qsrngherf.cuc%3Se%3Q228736oq%23750-og

Installing a dotorg theme is supposed to be governed by the WPCOM_Features::INSTALL_THEMES feature, and when using an ecommerce trial site, access to this feature looks to be correct: var_dump(wpcom_site_has_feature( WPCOM_Features::INSTALL_THEMES )); returns false.

We should confirm what the intended behaviour is and then implement it

Steps to reproduce

  1. Go to https://wordpress.com/ecommerce/
  2. Press Get Started and proceed all the way through the flow
  3. Go to wordpress.com/themes/:siteSlug
  4. Enter a search string and look for a community theme
  5. Notice that it displays an Upgrade badge saying you need at least a business plan
  6. Click on the theme

What you expected to happen

  • To see a CTA like "Upgrade to activate"
  • Clicking on the CTA should go to the checkout with the ecommerce plan
  • Once purchased the theme should be installed

What actually happened

I see an "Activate this design" button that activates the design.

Impact

One

Available workarounds?

There is no user impact

If the above answer is "Yes...", outline the workaround.

No response

Platform (Simple and/or Atomic)

No response

Logs or notes

No response

@dsas dsas added [Type] Bug Needs triage Ticket needs to be triaged [Feature] Theme Showcase The theme showcase screen in Calypso in Appearance > Themes. labels Sep 13, 2024
@daledupreez
Copy link
Contributor

The intended behaviour is that we shouldn't allow installation of external themes or plugins while on the Commerce trial plan. We set things up that way to prevent abuse of the Atomic platform.

This definitely sounds like a bug.

@dsas dsas added [Pri] High and removed [Pri] Low labels Sep 13, 2024
@github-actions github-actions bot added the [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts label Sep 13, 2024
@heavyweight heavyweight self-assigned this Sep 17, 2024
@jartes jartes added Triaged To be used when issues have been triaged. and removed Needs triage Ticket needs to be triaged labels Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Theme Showcase The theme showcase screen in Calypso in Appearance > Themes. [Pri] High [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Bug
Development

No branches or pull requests

4 participants