Disable Migrate Guru install when the white labeled plugin is used #94677

m1r0 · 2024-09-18T15:49:34Z

Resolves #94576

Proposed Changes

Create a new hook that won't install the Migrate Guru plugin and won't try to fetch the migration key from it.
Update the provisioning component to not show the following steps: Installing the required plugins and Getting the migration key.

Testing Instructions

Go to http://calypso.localhost:3000/setup/hosted-site-migration/.
Go through the flow until you reach the instructions step.
You should see the following instructions referencing Migrate Guru:

Go to your AT site and make sure the Migrate Guru plugin is installed as before.
Delete the Migrate Guru plugin from the AT site.
Now add &flags=migration-flow/enable-white-labeled-plugin to the URL and reload.
You should see the updated instructions referencing Migrate to WordPress.com:

Go to your AT site and make sure the Migrate Guru is not installed.

Pre-merge Checklist

Has the general commit checklist been followed? (PCYsg-hS-p2)
Have you written new tests for your changes?
Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
Have you checked for TypeScript, React or other console errors?
Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

github-actions · 2024-09-18T15:49:48Z

Calypso Live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-119935

Jetpack Cloud live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-119935&env=jetpack

Automattic for Agencies live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-119935&env=a8c-for-agencies

matticbot · 2024-09-18T15:58:15Z

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

blaze-dashboard
command-palette-wp-admin
help-center
notifications
odyssey-stats
whats-new
wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/disable-migrate-guru-install-when-using-the-move-plugin on your sandbox.

matticbot · 2024-09-18T16:01:21Z

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

m1r0 · 2024-09-18T16:39:53Z

...ng/stepper/declarative-flow/internals/steps-repository/site-migration-instructions/index.tsx

+	} = config.isEnabled( 'migration-flow/enable-white-labeled-plugin' )
+		? usePrepareSiteForMigrationWithMigrateToWPCOM( siteId ) // eslint-disable-line react-hooks/rules-of-hooks -- Temporary workaround until we completely replace the migrate guru hook.
+		: usePrepareSiteForMigrationWithMigrateGuru( siteId ); // eslint-disable-line react-hooks/rules-of-hooks


This is somewhat hacky but I don't think it can break the hook call order because the condition is a constant. Let me know if there's a better solution.

Note that this is expected to be cleaned up once the Migrate Guru hook is no longer used.

I would suggest creating a ticket as soon as possible because it may affect the code with the feature off.
I already had an issue caused by it that was very hard to detect. I can help with possible solutions.

Oh, thanks for pointing that out, Gabriel. I'm also sorry for any trouble it may have caused.

We're planning to clean this up in the following week or two. Should we prioritize fixing it before that? Is it causing any bugs right now?

I've created a card for it: #94750.

markbiek · 2024-09-18T16:47:48Z

@m1r0 A couple of things.

I think that unit test failure is real.
Related to item 1, we're still going to need a migration key, we'll just be calling a different endpoint for it. That overlaps with White-labeled migration plugin: Update front end to fetch key from new endpoint #94503 (which is dependent on White-labeled plugin: Add wpcom-migration key endpoint jetpack#39377).

So we may need a little coordination between you and @sixhours.

sixhours · 2024-09-18T17:26:36Z

Related to item 1, we're still going to need a migration key, we'll just be calling a different endpoint for it. That overlaps with #94503

That's correct! The front-end change for the migration key is ready for review in #94503

So this PR only needs to disable the Migrate Guru installation piece (and the software part of the progress indicator).

markbiek · 2024-09-18T17:32:40Z

Related to item 1, we're still going to need a migration key, we'll just be calling a different endpoint for it. That overlaps with #94503

That's correct! The front-end change for the migration key is ready for review in #94503

So this PR only needs to disable the Migrate Guru installation piece (and the software part of the progress indicator).

Got it! That makes sense.

The unit test will still need to be fixed temporarily though. Or maybe it's enough to just rebase once that other PR is merged?

markbiek · 2024-09-18T18:23:42Z

Just noting that I rebased and the test still fails. I probably won't have time to try and fix today so I'll leave it to you @m1r0 for tomorrow.

m1r0 · 2024-09-19T13:29:17Z

I think that unit test failure is real.

Thanks for catching that Mark!

That's correct! The front-end change for the migration key is ready for review in #94503
So this PR only needs to disable the Migrate Guru installation piece (and the software part of the progress indicator).

I've added the migration key logic back. It now works as before.

markbiek

LGTM!

m1r0 force-pushed the update/disable-migrate-guru-install-when-using-the-move-plugin branch from f81fa80 to 569474b Compare September 18, 2024 16:28

m1r0 marked this pull request as ready for review September 18, 2024 16:36

m1r0 requested review from markbiek and sixhours September 18, 2024 16:37

matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 18, 2024

m1r0 self-assigned this Sep 18, 2024

m1r0 commented Sep 18, 2024

View reviewed changes

markbiek force-pushed the update/disable-migrate-guru-install-when-using-the-move-plugin branch from 687dc5c to ab800d5 Compare September 18, 2024 18:08

m1r0 added 3 commits September 19, 2024 14:02

Disable Migrate Guru install when the white labeled plugin is used

656722f

Add tests

002253d

Fix the plugin name

ee655db

m1r0 force-pushed the update/disable-migrate-guru-install-when-using-the-move-plugin branch from ab800d5 to ee655db Compare September 19, 2024 11:02

m1r0 added 4 commits September 19, 2024 15:34

Revert the removal of the migration key check

4b818c5

Fix tests

6762a0c

Update tests

b0fbbca

Fix type error

475467f

markbiek approved these changes Sep 19, 2024

View reviewed changes

m1r0 merged commit 7eb2bfd into trunk Sep 19, 2024
11 checks passed

m1r0 deleted the update/disable-migrate-guru-install-when-using-the-move-plugin branch September 19, 2024 14:35

github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 19, 2024

m1r0 mentioned this pull request Sep 20, 2024

BlogVault White-labelled plugin: Fix calling hooks conditionally #94750

Closed

m1r0 mentioned this pull request Oct 3, 2024

White-labeled plugin: Install the wpcom-migration plugin from wp.org #95116

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disable Migrate Guru install when the white labeled plugin is used #94677

Disable Migrate Guru install when the white labeled plugin is used #94677

m1r0 commented Sep 18, 2024 •

edited

Loading

github-actions bot commented Sep 18, 2024 •

edited by matticbot

Loading

matticbot commented Sep 18, 2024 •

edited

Loading

matticbot commented Sep 18, 2024

m1r0 Sep 18, 2024

gabrielcaires Sep 19, 2024 •

edited

Loading

m1r0 Sep 20, 2024

m1r0 Sep 20, 2024

markbiek commented Sep 18, 2024

sixhours commented Sep 18, 2024

markbiek commented Sep 18, 2024 •

edited

Loading

markbiek commented Sep 18, 2024

m1r0 commented Sep 19, 2024 •

edited

Loading

markbiek left a comment

Disable Migrate Guru install when the white labeled plugin is used #94677

Disable Migrate Guru install when the white labeled plugin is used #94677

Conversation

m1r0 commented Sep 18, 2024 • edited Loading

Proposed Changes

Testing Instructions

Pre-merge Checklist

github-actions bot commented Sep 18, 2024 • edited by matticbot Loading

matticbot commented Sep 18, 2024 • edited Loading

matticbot commented Sep 18, 2024

m1r0 Sep 18, 2024

Choose a reason for hiding this comment

gabrielcaires Sep 19, 2024 • edited Loading

Choose a reason for hiding this comment

m1r0 Sep 20, 2024

Choose a reason for hiding this comment

m1r0 Sep 20, 2024

Choose a reason for hiding this comment

markbiek commented Sep 18, 2024

sixhours commented Sep 18, 2024

markbiek commented Sep 18, 2024 • edited Loading

markbiek commented Sep 18, 2024

m1r0 commented Sep 19, 2024 • edited Loading

markbiek left a comment

Choose a reason for hiding this comment

m1r0 commented Sep 18, 2024 •

edited

Loading

github-actions bot commented Sep 18, 2024 •

edited by matticbot

Loading

matticbot commented Sep 18, 2024 •

edited

Loading

gabrielcaires Sep 19, 2024 •

edited

Loading

markbiek commented Sep 18, 2024 •

edited

Loading

m1r0 commented Sep 19, 2024 •

edited

Loading