Skip to content
This repository has been archived by the owner on Jan 2, 2024. It is now read-only.

Refactor - SQLRepository uses sqlite3 instead of sqlalchemy #811

Merged
merged 16 commits into from
Nov 17, 2023
Merged

Refactor - SQLRepository uses sqlite3 instead of sqlalchemy #811

merged 16 commits into from
Nov 17, 2023

Conversation

toan-quach
Copy link
Member

No description provided.

@toan-quach toan-quach force-pushed the feature/use-sqlite3-for-sql-repo branch from acaab01 to 2b13eaa Compare November 3, 2023 03:06
@trgiangdo trgiangdo mentioned this pull request Nov 3, 2023
Closed
@toan-quach toan-quach force-pushed the feature/use-sqlite3-for-sql-repo branch from 186b455 to b6d9165 Compare November 7, 2023 04:10
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 10, 2023 •
edited
Loading

☂️ Python Cov

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
8401 7961 95% 85% 🟢

New Files

File Coverage Status
src/taipy/core/_repository/db/_sql_connection.py 95% 🟢
TOTAL 95% 🟢

Modified Files

File Coverage Status
src/taipy/core/_core.py 100% 🟢
src/taipy/core/_repository/_base_taipy_model.py 87% 🟢
src/taipy/core/_repository/_encoder.py 84% 🟢
src/taipy/core/_repository/_sql_repository.py 89% 🟢
src/taipy/core/_version/_cli/_version_cli.py 96% 🟢
src/taipy/core/_version/_version_model.py 100% 🟢
src/taipy/core/_version/_version_sql_repository.py 100% 🟢
src/taipy/core/cycle/_cycle_model.py 100% 🟢
src/taipy/core/data/_data_model.py 100% 🟢
src/taipy/core/job/_job_model.py 100% 🟢
src/taipy/core/scenario/_scenario_model.py 100% 🟢
src/taipy/core/task/_task_model.py 100% 🟢
TOTAL 96% 🟢

updated for commit: 9b4ddf2 by action🐍

@trgiangdo trgiangdo changed the title [BLOCK] draft moving to sqlite3 Refactor - SQLRepository uses sqlite3 instead of sqlalchemy Nov 11, 2023
trgiangdo
trgiangdo reviewed Nov 11, 2023
View reviewed changes
Copy link
Member

@trgiangdo trgiangdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some small comments.

Other than that, there are a lot of # type: ignore due to the ModelType in _sql_repository. We will need to come back to the typing in the future.

src/taipy/core/_repository/_sql_repository.py Outdated Show resolved Hide resolved
src/taipy/core/_repository/_sql_repository.py Outdated Show resolved Hide resolved
@toan-quach toan-quach requested a review from trgiangdo November 13, 2023 04:29
trgiangdo
trgiangdo previously approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@trgiangdo trgiangdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of # type: ignore have been removed. Neat :D

@florian-vuillemot
Copy link
Member

Can "sqlachemy" be removed from setup.py and Pipfile?

@toan-quach
Copy link
Member Author

@florian-vuillemot sadly no since we still need it for the SQL Datanode

@toan-quach toan-quach force-pushed the feature/use-sqlite3-for-sql-repo branch from c9387fb to ab62803 Compare November 15, 2023 12:52
@toan-quach toan-quach merged commit 89b0202 into develop Nov 17, 2023
41 of 42 checks passed
@toan-quach toan-quach deleted the feature/use-sqlite3-for-sql-repo branch November 17, 2023 02:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joaoandre-avaiga joaoandre-avaiga joaoandre-avaiga approved these changes

@jrobinAV jrobinAV jrobinAV approved these changes

@trgiangdo trgiangdo trgiangdo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@toan-quach @florian-vuillemot @trgiangdo @jrobinAV @joaoandre-avaiga