feature/#806 move name attribute of dn to properties #812

toan-quach · 2023-10-30T14:44:34Z

tests/core/notification/test_notifier.py

tests/core/data/test_data_repositories.py

github-actions · 2023-11-03T10:24:16Z

☂️ Python Cov

current status: ✅

Lines	Covered	Coverage	Threshold	Status
8164	7755	95%	85%	🟢

No new covered files...

File	Coverage	Status
src/taipy/core/_entity/_migrate/_utils.py	85%	🟢
src/taipy/core/data/_abstract_sql.py	90%	🟢
src/taipy/core/data/_data_converter.py	97%	🟢
src/taipy/core/data/_data_manager.py	99%	🟢
src/taipy/core/data/_data_model.py	100%	🟢
src/taipy/core/data/csv.py	95%	🟢
src/taipy/core/data/data_node.py	98%	🟢
src/taipy/core/data/excel.py	97%	🟢
src/taipy/core/data/generic.py	98%	🟢
src/taipy/core/data/in_memory.py	100%	🟢
src/taipy/core/data/json.py	95%	🟢
src/taipy/core/data/mongo.py	99%	🟢
src/taipy/core/data/parquet.py	98%	🟢
src/taipy/core/data/pickle.py	100%	🟢
src/taipy/core/data/sql.py	97%	🟢
src/taipy/core/data/sql_table.py	92%	🟢
TOTAL	96%	🟢

updated for commit: d51b336 by action🐍

trgiangdo

LGTM

jrobinAV reviewed Oct 30, 2023

View reviewed changes

tests/core/notification/test_notifier.py Show resolved Hide resolved

tests/core/data/test_data_repositories.py Show resolved Hide resolved

move name attribute of dn to properties

74a7ddb

toan-quach force-pushed the feature/move-name-to-properties-dict-for-dn branch from d388f6e to 74a7ddb Compare November 2, 2023 09:38

feat: name should be inside of data_node_properties on migrated entities

c976117

trgiangdo previously approved these changes Nov 3, 2023

View reviewed changes

trgiangdo requested a review from jrobinAV November 3, 2023 11:06

fix: sort parents list when migrate entities

d51b336

trgiangdo dismissed their stale review via d51b336 November 3, 2023 11:10

trgiangdo force-pushed the feature/move-name-to-properties-dict-for-dn branch from a9efcc5 to d51b336 Compare November 3, 2023 11:10

trgiangdo approved these changes Nov 3, 2023

View reviewed changes

jrobinAV approved these changes Nov 6, 2023

View reviewed changes

toan-quach merged commit 63fcfb7 into develop Nov 6, 2023
41 of 42 checks passed

toan-quach deleted the feature/move-name-to-properties-dict-for-dn branch November 6, 2023 10:03