From 67c90a2140030146c795bcd81ebff6678ca9a455 Mon Sep 17 00:00:00 2001
From: Joseph Sawyer <joseph@jcsawyer.com>
Date: Sat, 21 Dec 2024 22:09:09 +0000
Subject: [PATCH] feat: add hidesuggestions property to textbox

---
 samples/ControlCatalog/Pages/TextBoxPage.xaml |  1 +
 .../Platform/Input/AndroidInputMethod.cs      |  3 ++
 .../Input/TextInput/TextInputOptions.cs       | 33 +++++++++++++++++++
 .../TextInputResponder.Properties.cs          | 15 +++++++--
 4 files changed, 50 insertions(+), 2 deletions(-)

diff --git a/samples/ControlCatalog/Pages/TextBoxPage.xaml b/samples/ControlCatalog/Pages/TextBoxPage.xaml
index 058bcff84de..425a1b376a0 100644
--- a/samples/ControlCatalog/Pages/TextBoxPage.xaml
+++ b/samples/ControlCatalog/Pages/TextBoxPage.xaml
@@ -38,6 +38,7 @@
                  UseFloatingWatermark="True"
                  PasswordChar="*"
                  Text="Password" />
+        <TextBox Width="200" Watermark="Hide suggestions" TextInputOptions.HideSuggestions="True" />
         <TextBox Width="200" Text="Left aligned text" TextAlignment="Left" AcceptsTab="True" />
         <TextBox Width="200" Text="Center aligned text" TextAlignment="Center" />
         <TextBox Width="200" Text="Right aligned text" TextAlignment="Right" />
diff --git a/src/Android/Avalonia.Android/Platform/Input/AndroidInputMethod.cs b/src/Android/Avalonia.Android/Platform/Input/AndroidInputMethod.cs
index cb105197cbc..fec48a1c9c1 100644
--- a/src/Android/Avalonia.Android/Platform/Input/AndroidInputMethod.cs
+++ b/src/Android/Avalonia.Android/Platform/Input/AndroidInputMethod.cs
@@ -172,6 +172,9 @@ public void SetOptions(TextInputOptions options)
                 if (options.Multiline)
                     outAttrs.InputType |= InputTypes.TextFlagMultiLine;
 
+                if (outAttrs.InputType is InputTypes.ClassText && options.HideSuggestions)
+                    outAttrs.InputType |= InputTypes.TextVariationPassword | InputTypes.TextFlagNoSuggestions;
+                    
                 outAttrs.ImeOptions = options.ReturnKeyType switch
                 {
                     TextInputReturnKeyType.Return => ImeFlags.NoEnterAction,
diff --git a/src/Avalonia.Base/Input/TextInput/TextInputOptions.cs b/src/Avalonia.Base/Input/TextInput/TextInputOptions.cs
index c33f5641a85..65662b0f7c4 100644
--- a/src/Avalonia.Base/Input/TextInput/TextInputOptions.cs
+++ b/src/Avalonia.Base/Input/TextInput/TextInputOptions.cs
@@ -253,4 +253,37 @@ public static bool GetIsSensitive(StyledElement avaloniaObject)
     /// Text contains sensitive data like card numbers and should not be stored  
     /// </summary>
     public bool IsSensitive { get; set; }
+    
+    /// <summary>
+    /// Defines the <see cref="HideSuggestions"/> property.
+    /// </summary>
+    public static readonly AttachedProperty<bool> HideSuggestionsProperty =
+        AvaloniaProperty.RegisterAttached<TextInputOptions, StyledElement, bool>(
+            "HideSuggestions",
+            inherits: true);
+    
+    /// <summary>
+    /// Sets the value of the attached <see cref="HideSuggestionsProperty"/> on a control.
+    /// </summary>
+    /// <param name="avaloniaObject">The control.</param>
+    /// <param name="value">The property value to set.</param>
+    public static void SetHideSuggestions(StyledElement avaloniaObject, bool value)
+    {
+        avaloniaObject.SetValue(HideSuggestionsProperty, value);
+    }
+
+    /// <summary>
+    /// Gets the value of the attached <see cref="HideSuggestionsProperty"/>.
+    /// </summary>
+    /// <param name="avaloniaObject">The target.</param>
+    /// <returns>true if HideSuggestions</returns>
+    public static bool GetHideSuggestions(StyledElement avaloniaObject)
+    {
+        return avaloniaObject.GetValue(HideSuggestionsProperty);
+    }
+    
+    /// <summary>
+    /// Hide virtual keyboard suggestions
+    /// </summary>
+    public bool HideSuggestions { get; set; }
 }
diff --git a/src/iOS/Avalonia.iOS/TextInputResponder.Properties.cs b/src/iOS/Avalonia.iOS/TextInputResponder.Properties.cs
index ab0d92e5fae..219e2847581 100644
--- a/src/iOS/Avalonia.iOS/TextInputResponder.Properties.cs
+++ b/src/iOS/Avalonia.iOS/TextInputResponder.Properties.cs
@@ -12,7 +12,12 @@ partial class TextInputResponder
         public UITextAutocapitalizationType AutocapitalizationType { get; private set; }
 
         [Export("autocorrectionType")]
-        public UITextAutocorrectionType AutocorrectionType => UITextAutocorrectionType.Yes;
+        public UITextAutocorrectionType AutocorrectionType =>
+            _view._options == null ?
+                UITextAutocorrectionType.Yes :
+                _view._options.HideSuggestions ?
+                    UITextAutocorrectionType.No :
+                    UITextAutocorrectionType.Yes;
 
         [Export("keyboardType")]
         public UIKeyboardType KeyboardType =>
@@ -64,7 +69,13 @@ public UIReturnKeyType ReturnKeyType
             _view._options?.ContentType is TextInputContentType.Password or TextInputContentType.Pin 
             || (_view._options?.IsSensitive ?? false);
 
-        [Export("spellCheckingType")] public UITextSpellCheckingType SpellCheckingType => UITextSpellCheckingType.Yes;
+        [Export("spellCheckingType")]
+        public UITextSpellCheckingType SpellCheckingType =>
+            _view._options == null ?
+                UITextSpellCheckingType.Yes :
+                _view._options.HideSuggestions ?
+                    UITextSpellCheckingType.No :
+                    UITextSpellCheckingType.Yes;
 
         [Export("textContentType")] public NSString TextContentType { get; set; } = new NSString("text/plain");