Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloudEventKafkaMessageConverter when converting to CloudEvent can ignore metadata keys that are not valid extension names #511

Merged

Conversation

aupodogov
Copy link
Contributor

This PR adds an ability to ignore metadata keys that are not valid extension names when converting to CloudEvent thus not throwing InvalidMetaDataException. Warn message is logged instead of exception.

…ore metadata keys that are not valid extension names
@gklijs gklijs self-requested a review June 6, 2024 11:04
Copy link

@gklijs gklijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks.

@gklijs gklijs merged commit b3cd243 into AxonFramework:master Jun 6, 2024
5 of 6 checks passed
Copy link
Member

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants