-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add missing dns zones in relevant policy assignment and adjust workflow permissions #902
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oZakari
added
Area: Policy 📝
Issues / PR's related to Policy
Type: Bug 🪲
Something isn't working
labels
Nov 13, 2024
/azp run validateazcloud |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run validateazcloud |
Azure Pipelines successfully started running 1 pipeline(s). |
jtracey93
requested changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice @oZakari, does this var also need updating? https://github.com/Azure/ALZ-Bicep/blob/main/infra-as-code/bicep/modules/policy/assignments/alzDefaults/alzDefaultPolicyAssignments.bicep#L535-L589
microsoft-github-policy-service
bot
added
the
Needs: Author Feedback 👂
Needs the author to provide feedback
label
Nov 14, 2024
oZakari
changed the title
fix: Add missing dns zones in relevant policy assignment
fix: Add missing dns zones in relevant policy assignment and adjust workflow permissions
Nov 15, 2024
microsoft-github-policy-service
bot
removed
the
Needs: Author Feedback 👂
Needs the author to provide feedback
label
Nov 15, 2024
oZakari
force-pushed
the
fix-dns-policy-assignment
branch
from
November 15, 2024 23:09
f76b6e5
to
fd6168e
Compare
…i/ALZ-Bicep into fix-dns-policy-assignment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
This pull request includes several updates to GitHub workflows and a significant change to a Bicep module template. The updates to the workflows involve setting permissions for reading contents, while the Bicep module template changes involve updating and adding various private DNS zone IDs.
Workflow Updates:
permissions: contents: read
to the following workflow files to ensure they have the necessary read permissions:.github/workflows/bicep-build-to-validate.yml
.github/workflows/gh-ado-sync.yml
.github/workflows/release-tests.yml
.github/workflows/scheduled-bicep-build.yml
Bicep Module Template Changes:
infra-as-code/bicep/modules/policy/assignments/lib/policy_assignments/policy_assignment_es_deploy_private_dns_zones.tmpl.json
to correct and add various private DNS zone IDs, ensuring accurate resource ID references and expanding the list of supported DNS zones.Related Issues/Work Items
Fixes #897
This PR fixes/adds/changes/removes
Breaking Changes
None
Testing Evidence
Replace this with any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).
As part of this Pull Request I have
.bicep
file/s I am adding/editing are using the latest API version possiblemain
branch