Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update management groups custom name documentation with policy assignments examples. #30

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

haflidif
Copy link
Contributor

This pull request includes an important update to the docs/content/accelerator/startermodules/terraform-platform-landing-zone/options/management-groups.md file. The change ensures that any updates to management group IDs are consistently reflected in the platform-landing-zone.tfvars file.

Key change:

  • Added instructions and an example for updating the policy_assignments_to_modify in the platform-landing-zone.tfvars file to match any changes made to management group IDs. This ensures that policy assignments are correctly aligned with the updated IDs.

@jaredfholgate jaredfholgate self-requested a review January 14, 2025 11:03
Copy link
Member

@jaredfholgate jaredfholgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haflidif
Copy link
Contributor Author

Do we need another reviewer on this PR since you also did some changes in the code @jaredfholgate ? or can it be merge without additional reviewer / approver ?

Copy link
Contributor Author

@haflidif haflidif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jaredfholgate
Copy link
Member

Do we need another reviewer on this PR since you also did some changes in the code @jaredfholgate ? or can it be merge without additional reviewer / approver ?

I asked @matt-FFFFFF to review it earlier.

@matt-FFFFFF
Copy link
Member

Apologies. Done now

@matt-FFFFFF matt-FFFFFF merged commit 5409991 into Azure:main Jan 14, 2025
3 checks passed
@haflidif haflidif deleted the hf-patch-mgmt-group-docs branch January 15, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants