Skip to content

Commit

Permalink
Portal RI: Fix IP address space overlap with FW/VPN (#1443)
Browse files Browse the repository at this point in the history
  • Loading branch information
Springstone authored Oct 17, 2023
1 parent 5e3d800 commit 726b55b
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
1 change: 1 addition & 0 deletions docs/wiki/Whats-new.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ Here's what's changed in Enterprise Scale/Azure Landing Zones:

#### Tooling

- Fixed a bug in the portal accelerator experience when deploying a VPN Gateway and Azure Firewall (Basic SKU) - IP address overlap error.
- Added vWAN Hub Routing Intent support to Portal Accelerator for scenarios that include Azure Firewall deployment
- Enhanced the ALZ Portal Accelerator to provide the ability to deploy the Azure VPN Gateway in Active/Active mode as per feedback from [#655](https://github.com/Azure/Enterprise-Scale/issues/655).

Expand Down
2 changes: 1 addition & 1 deletion eslzArm/eslz-portal.json
Original file line number Diff line number Diff line change
Expand Up @@ -1925,7 +1925,7 @@
"type": "Microsoft.Common.TextBox",
"label": "Subnet for Azure Firewall Mgmt (Optional Only for Basic SKU)",
"toolTip": "Provide address prefix in CIDR notation (e.g 10.100.0.0/26)",
"defaultValue": "10.100.1.0/26",
"defaultValue": "10.100.2.0/24",
"visible": "[and(equals(steps('connectivity').enableAzFw, 'Yes'), equals(steps('connectivity').firewallSku, 'Basic'), not(equals(steps('connectivity').enableHub, 'vwan')))]",
"constraints": {
"required": true,
Expand Down
3 changes: 2 additions & 1 deletion eslzArm/subscriptionTemplates/hubspoke-connectivity.json
Original file line number Diff line number Diff line change
Expand Up @@ -548,7 +548,8 @@
"dependsOn": [
"[concat('Microsoft.Network/firewallPolicies/', variables('azFwPolicyName'))]",
"[concat('Microsoft.Network/publicIpAddresses/', variables('azFwIpName'))]",
"[concat('Microsoft.Network/virtualNetworks/', variables('hubName'))]"
"[concat('Microsoft.Network/virtualNetworks/', variables('hubName'))]",
"[concat('Microsoft.Network/virtualNetworkGateways/', variables('vpngwname'))]"
],
"properties": {
"sku": {
Expand Down

0 comments on commit 726b55b

Please sign in to comment.