Allow Log Collector to run without CPU/Memory limits #2883
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lector resource enforcement, allowing it to run Fix ownership
…n as it's a dead symlink. added validation for this scenario
Re-enabled agent updates
…he following Criteria is met: - OS is on CGroupv2 - Uncapped flag is used
…f OS env __CGROUPS_FLAG_ENV_VARIABLE is set to 1 and is in use CGroup is not v2
… param from waagent.conf
…temd_cmd for Uncapped flag + CGroupv2
jovieir
requested review from
narrieta,
ZhidongPeng and
nagworld9
as code owners
|
@jovieir Thank you for your contribution. I'm closing this PR since there is an internal conversation on this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The log collector will not run for distros running under CGroup2 due to LogCollectorMonitor dependency from CGroup1 metrics. This change will allow the LC to run, bypassing the monitor and resource usage, being effectively unconstrained.
Two distinct ways to run:
During testing, found an issue where a linked file to be collected no longer existed (removed after successful bootstrapping), causing an unhandled exception + logcollection to fail. Fixed with validation if symlink path file exists before appending to files to collect.
Issue #
PR information
Quality of Code and Contribution Guidelines