Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the write path, a Write lock is needed in the slow path to ensure a segment exists. This was getting hit more frquently than expected because we roll segments more quickly and the max segment size triggers a rollover more frequently.
To address, this we create a new segment when we rotate proactive so that the slow patch for writes isn't hit as oftent. The side effect of this is that if writes not frequent, we roll over emtpy segments frequently. If we try to upload them, they show up as ingestion failures in kusto because the file has no rows. To address this issue, we just remove the segment if it only contains the segment magic header bytes.