Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize WAL storage #65

Merged
merged 6 commits into from
Jul 14, 2023
Merged

Generalize WAL storage #65

merged 6 commits into from
Jul 14, 2023

Conversation

jwilder
Copy link
Collaborator

@jwilder jwilder commented Jul 14, 2023

This extracts the wal that was used for metrics into a more generic framework that can be used for metrics, logs or other data. The existing wal segments have been converted to a compressed binary format with checksum and compressions. This significantly reduces disk IO, storage size and increases ingestion throughput by 4x.

This extracts the WAL from the metrics storage so that it can be
used for other data types such as logs.  This also changes the
on-disk format to support compressions, checksums and better memory
utilization.
This is significantly faster and more efficient from a throughput
and disk size perspective.
Copy link
Member

@jessejlt jessejlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments

tools/cmd/walreader/main.go Outdated Show resolved Hide resolved
pkg/wal/iterator.go Outdated Show resolved Hide resolved
pkg/wal/segment.go Outdated Show resolved Hide resolved
pkg/wal/segment.go Show resolved Hide resolved
Copy link
Member

@jessejlt jessejlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Will be substantially easier to add logs now

@jwilder jwilder merged commit b094392 into main Jul 14, 2023
3 checks passed
@jwilder jwilder deleted the jwilder/ingestor branch July 14, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants