Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add description to policy defaults #186

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

matt-FFFFFF
Copy link
Member

@matt-FFFFFF matt-FFFFFF commented Nov 5, 2024

Adds description field to policy default values. Modifies documentation output to tabular format and include description when available.

Example output:

Policy Default Values

The following policy default values are available in this library:

default name ama_change_tracking_data_collection_rule_id

The data collection rule id that should be used for the change tracking deployment.

ASSIGNMENT PARAMETER NAMES
Deploy-VM-ChangeTrack dcrResourceId
Deploy-VMSS-ChangeTrack dcrResourceId
Deploy-vmArc-ChangeTrack dcrResourceId

default name ama_mdfc_sql_data_collection_rule_id

The data collection rule id that should be used for the SQL MDFC deployment.

ASSIGNMENT PARAMETER NAMES
Deploy-MDFC-DefSQL-AMA dcrResourceId

@matt-FFFFFF matt-FFFFFF changed the title feat: add description to policy defaults feat!: add description to policy defaults Nov 5, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 34.21053% with 25 lines in your changes missing coverage. Please review.

Project coverage is 48.83%. Comparing base (c78de13) to head (ba7cae3).

Files with missing lines Patch % Lines
defaultPolicyAssignmentValues.go 47.82% 12 Missing ⚠️
internal/doc/doc.go 0.00% 10 Missing ⚠️
alzlib.go 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #186      +/-   ##
==========================================
- Coverage   48.91%   48.83%   -0.08%     
==========================================
  Files          39       39              
  Lines        2437     2455      +18     
==========================================
+ Hits         1192     1199       +7     
- Misses       1083     1095      +12     
+ Partials      162      161       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jaredfholgate jaredfholgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matt-FFFFFF matt-FFFFFF added this pull request to the merge queue Nov 5, 2024
Merged via the queue into main with commit bf74df7 Nov 5, 2024
7 checks passed
@matt-FFFFFF matt-FFFFFF deleted the feat/defaultsDescription branch November 5, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants