Skip to content

Commit

Permalink
Increase version to 2.4.3
Browse files Browse the repository at this point in the history
  • Loading branch information
@xinchen10
xinchen10 committed Jun 9, 2021
1 parent 44913ca commit a9ee7bb
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/Properties/Version.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,5 @@
// Revision
//
[assembly: AssemblyVersion("2.1.0")]
[assembly: AssemblyFileVersion("2.4.2")]
[assembly: AssemblyInformationalVersion("2.4.2")]
[assembly: AssemblyFileVersion("2.4.3")]
[assembly: AssemblyInformationalVersion("2.4.3")]

4 comments on commit a9ee7bb

@filip1410
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @xinchen10,
Can you explain why the assembly version is not changed when a new version is built ?
best regards

@Havret
Copy link
Contributor

@Havret Havret commented on a9ee7bb Jun 15, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @filip1410
We don't release a new version on each build. We are doing explicit releases when the need arises. I hope that answers your question.

On the other hand @xinchen10, what do you think about automating the whole thing? For instance, as I have done for .NET Client for ActiveMQ Artemis? All you would need to do is to create a release using GitHub, and the workflow would be triggered to build the lib and push the artifacts to NuGet.

@xinchen10
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@filip1410 we increase assembly version only when there is a breaking change. Assembly version is part of the assembly identity. If that changes, some apps may break if they don't recompile the code or define a binding redirect.

@Havret that's a good idea.

@filip1410
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks or your replies. It's perfectly clear.

Please sign in to comment.