Support for spaces in Active Directory group names #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delete unused variables to avoid Bicep warnings Bicep linting
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -182,7 +182,8 @@ | |||
|
|
|||
| Write-Log "Unmounting drive" | |||
| # Remove-PSDrive -Name $DriveLetter -Force | |||
| net use ${DriveLetter} /delete | |||
| # HACK: Disabled because it fails | |||
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
There was a problem hiding this comment.
Unable to find a fix for this at this time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
Fix the storage account domain join script arguments to support spaces in AD group names.
This PR fixes/adds/changes/removes
Breaking Changes
N/A
Testing Evidence
Successful deployment with an AD group name All Employees.
As part of this Pull Request I have
.bicepfile/s I am adding/editing are using the latest API version possiblemainbranch