Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User assigned IDs and DSC package versioning #532

Merged
merged 6 commits into from
Nov 8, 2023
Merged

Conversation

danycontre
Copy link
Collaborator

Overview/Summary

Replace this with a brief description of what this Pull Request fixes, changes, etc.

This PR fixes/adds/changes/removes

  1. Removes the assignment of the storage managed identity ID to the session hosts as user assigned identity.
  2. Introduces versioning of the DSC package for FSLogix storage setup.

Breaking Changes

  1. DSC package (DSCStorageScripts.zip) location was changed to adopt a versioning folder (avdaccelerator\workload\scripts\DSCStorageScripts\1.0.0). Keeping same version of the file on the original path to avoid failures, though it will be removed with the delivery of the next version.

Testing Evidence

Replace this with any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

As part of this Pull Request I have

  • [ x] Read the Contribution Guide and ensured this PR is compliant with the guide
  • [ x] Ensured the resource API versions in .bicep file/s I am adding/editing are using the latest API version possible
  • [ x] Checked for duplicate Pull Requests
  • [ x] Associated it with relevant GitHub Issues
  • [ x] (AVD LZA Team Only) Associated it with relevant ADO Items
  • [ x] Ensured my code/branch is up-to-date with the latest changes in the main branch
  • [ x] Performed testing and provided evidence.
  • [ x] Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Docs etc.)

@danycontre danycontre merged commit 4d79165 into main Nov 8, 2023
9 checks passed
@danycontre danycontre deleted the ids-updates branch November 8, 2023 19:26
petersonjdNIH pushed a commit to ARPA-H/avdaccelerator-nih that referenced this pull request Aug 26, 2024
User assigned IDs and DSC package versioning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant