Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix property name mismatch to set NSG and RT on subnets #724

Merged
merged 4 commits into from
Dec 19, 2024

Conversation

SvenAelterman
Copy link
Contributor

@SvenAelterman SvenAelterman commented Dec 18, 2024

Overview/Summary

Closes #723

This PR fixes/adds/changes/removes

  1. Adds the word Resource in the property names of the network security group and route table resource ID properties that are passed to the AVM network module.

Breaking Changes

N/A

Testing Evidence

N/A

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Ensured the resource API versions in .bicep file/s I am adding/editing are using the latest API version possible
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • (AVD LZA Team Only) Associated it with relevant ADO Items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Docs etc.)

@danycontre danycontre merged commit 3a3c577 into Azure:main Dec 19, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: NSG and RT assignments missing on subnets
2 participants