chore: address comments

test/internal/kubernetes/utils.go

@@ -489,6 +489,9 @@ func RestartKubeProxyService(ctx context.Context, clientset *kubernetes.Clientse
 			return errors.Wrapf(err, "failed to get privileged pod on node %s", node.Name)
 		}
 
+		if len(pod.Items) == 0 {
+			return errors.Errorf("there are no privileged pods on node - %v", node.Name)
+		}
 		privilegedPod := pod.Items[0]
 		// exec into the pod and restart kubeproxy
 		_, err = ExecCmdOnPod(ctx, clientset, privilegedNamespace, privilegedPod.Name, restartKubeProxyCmd, config)

test/validate/linux_validate.go

@@ -214,11 +214,13 @@ func (v *Validator) validateRestartNetwork(ctx context.Context) error {
 			continue
 		}
 		// get the privileged pod
-		pod, err := acnk8s.GetPodsByNode(ctx, v.clientset, privilegedNamespace, privilegedLabelSelector, nodes.Items[index].Name)
+		pod, err := acnk8s.GetPodsByNode(ctx, v.clientset, privilegedNamespace, privilegedLabelSelector, node.Name)
 		if err != nil {
 			return errors.Wrapf(err, "failed to get privileged pod")
 		}
-
+		if len(pod.Items) == 0 {
+			return errors.Errorf("there are no privileged pods on node - %v", node.Name)
+		}
 		privilegedPod := pod.Items[0]
 		// exec into the pod to get the state file
 		_, err = acnk8s.ExecCmdOnPod(ctx, v.clientset, privilegedNamespace, privilegedPod.Name, restartNetworkCmd, v.config)

test/validate/validate.go

@@ -73,17 +73,14 @@ func CreateValidator(ctx context.Context, clientset *kubernetes.Clientset, confi
 	switch os {
 	case "windows":
 		checks = windowsChecksMap[cni]
-	case "linux":
-		checks = linuxChecksMap[cni]
-	default:
-		return nil, errors.Errorf("unsupported os: %s", os)
-	}
-
-	if os == "windows" {
 		err := acnk8s.RestartKubeProxyService(ctx, clientset, privilegedNamespace, privilegedLabelSelector, config)
 		if err != nil {
 			return nil, errors.Wrapf(err, "failed to restart kubeproxy")
 		}
+	case "linux":
+		checks = linuxChecksMap[cni]
+	default:
+		return nil, errors.Errorf("unsupported os: %s", os)
 	}
 
 	return &Validator{
@@ -138,6 +135,9 @@ func (v *Validator) validateIPs(ctx context.Context, stateFileIps stateFileIpsFu
 		if err != nil {
 			return errors.Wrapf(err, "failed to get privileged pod")
 		}
+		if len(pod.Items) == 0 {
+			return errors.Errorf("there are no privileged pods on node - %v", nodes.Items[index].Name)
+		}
 		podName := pod.Items[0].Name
 		// exec into the pod to get the state file
 		result, err := acnk8s.ExecCmdOnPod(ctx, v.clientset, namespace, podName, cmd, v.config)

test/validate/windows_validate.go

@@ -204,7 +204,9 @@ func validateHNSNetworkState(ctx context.Context, nodes *corev1.NodeList, client
 		if err != nil {
 			return errors.Wrap(err, "failed to get privileged pod")
 		}
-
+		if len(pod.Items) == 0 {
+			return errors.Errorf("there are no privileged pods on node - %v", nodes.Items[index].Name)
+		}
 		podName := pod.Items[0].Name
 		// exec into the pod to get the state file
 		result, err := acnk8s.ExecCmdOnPod(ctx, clientset, privilegedNamespace, podName, hnsNetworkCmd, restConfig)