add a new container type for l1vh singularity container request #2215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cns/NetworkContainerContract.go
Outdated
| @@ -95,6 +96,8 @@ type CreateNetworkContainerRequest struct { | |||
| AllowHostToNCCommunication bool | |||
| AllowNCToHostCommunication bool | |||
| EndpointPolicies []NetworkContainerRequestPolicies | |||
| BackendNetworkInterfaceID string | |||
There was a problem hiding this comment.
can it move inside a structure which contains backendnetwork info?
There was a problem hiding this comment.
yes I can add a struct BackendNetworkInfo with these 2 new fields
There was a problem hiding this comment.
@tamilmani1989 - should I be reusing the fields added by PR - 3b1c720#diff-cc7993ab0a3ea963068707fda61d4664fbac1ccf3ab3bfaf0949491d90ad7f3fR85 - only thing I'm not sure of is why PodIpInfo is being used instead of adding this to CreateNetworkContainerRequest, how are these fields sent to CNS by DNC & to be consumed by DNC? I was making this change so DNC can create a NCRequest with these fields to send to CNS..not sure if that part of change has been implemented yet for swiftv2? @rbtr
tamilmani1989
previously approved these changes
Sep 22, 2023
neaggarwMS
requested changes
Sep 25, 2023
kmurudi
force-pushed
the
Singularity_backendNCGoalState
branch
from
c8e1ea5 to
095ff5c
Compare
kmurudi
commented
Oct 13, 2023
kmurudi
force-pushed
the
Singularity_backendNCGoalState
branch
2 times, most recently
from
d7150d5 to
701346a
Compare
kmurudi
force-pushed
the
Singularity_backendNCGoalState
branch
from
38ac09f to
ce4f8b7
Compare
neaggarwMS
previously approved these changes
Oct 24, 2023
jaer-tsun
reviewed
Oct 26, 2023
kmurudi
force-pushed
the
Singularity_backendNCGoalState
branch
from
ce4f8b7 to
7b2b839
Compare
paulyufan2
force-pushed
the
Singularity_backendNCGoalState
branch
from
7b2b839 to
2898688
Compare
rbtr
approved these changes
Oct 27, 2023
kmurudi
force-pushed
the
Singularity_backendNCGoalState
branch
from
2898688 to
ab679f2
Compare
…be used by CNI ADD net-plugin
kmurudi
force-pushed
the
Singularity_backendNCGoalState
branch
from
ab679f2 to
8467aad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
design doc - https://microsoft.sharepoint.com/:w:/t/Aznet/EQqTVNaVUBJDsRbhxwlMFP4BPAqGRM_9-RQiOkoMt7FyxA?e=kYTEJZ
Requirements:
Notes: