fix: Add SubnetGUID to MT PodNetwork CRD #2321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samarths-msft
requested review from
tamilmani1989,
miguelgoms,
thatmattlong and
aggarwal0009
aggarwal0009
previously approved these changes
Oct 25, 2023
nddq
force-pushed
the
samarths/subnetguid
branch
from
5cf410e to
1a50622
Compare
samarths-msft
changed the title
isaac-dasan
previously approved these changes
Oct 27, 2023
miguelgoms
requested changes
Oct 27, 2023
samarths-msft
dismissed stale reviews from isaac-dasan and aggarwal0009
via
9c87eef
samarths-msft
changed the title
miguelgoms
approved these changes
Oct 27, 2023
aggarwal0009
approved these changes
Oct 30, 2023
jaer-tsun
approved these changes
Oct 30, 2023
nddq
force-pushed
the
samarths/subnetguid
branch
2 times, most recently
from
8e58ea8 to
5047c41
Compare
samarths-msft
force-pushed
the
samarths/subnetguid
branch
from
5047c41 to
208eb6c
Compare
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
samarths-msft
force-pushed
the
samarths/subnetguid
branch
from
208eb6c to
cbc14bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Multi-tenancy orchestrator needs to submit Azure Subnet ResourceGUID to PN CRD, in addition to ARM Resource ID.
Issue Fixed:
Requirements:
Notes: