fix: NPM Changed Allow All Policy for Ingress and Egress #2409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h other rules in netpol and added tests.
rayaisaiah
changed the title
vakalapa
approved these changes
Nov 30, 2023
matmerr
pushed a commit
that referenced
this pull request
Jan 17, 2024
Changed allow all policy for ingress and egress to allow all even with other rules in netpol and added tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed allow all policy for ingress and egress for npm to allow all even with other rules in the network policy and added new test cases to confirm the changes work.
Reason for Change: This change is in alignment with functionality of other network policy tools such as Calico.
Issue Fixed: https://portal.microsofticm.com/imp/v3/incidents/incident/442655848/summary
Requirements: