Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add date to cilium nightly cluster name #2425

Merged
merged 1 commit into from
Jan 3, 2024
Merged

ci: add date to cilium nightly cluster name #2425

merged 1 commit into from
Jan 3, 2024

Conversation

vipul-21
Copy link
Contributor

@vipul-21 vipul-21 commented Dec 5, 2023 •
edited
Loading

Reason for Change:
Adding timestamp for the nightly cilium pipeline.\

Issue Fixed:

Requirements:

Notes:

@vipul-21 vipul-21 added the ci Infra or tooling. label Dec 5, 2023
@vipul-21 vipul-21 requested a review from a team as a code owner December 5, 2023 21:41
@vipul-21 vipul-21 requested a review from debecerra December 5, 2023 21:41
jpayne3506
jpayne3506 approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@jpayne3506 jpayne3506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Friendly reminder max character for a cluster name should be 14 in order to consume large region names.

@vipul-21 vipul-21 force-pushed the singhvipul/ciliumtimestamp branch from e7d6c98 to 6553d77 Compare December 8, 2023 17:13
@vipul-21 vipul-21 enabled auto-merge (squash) December 8, 2023 17:13
@vipul-21
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@vipul-21 vipul-21 force-pushed the singhvipul/ciliumtimestamp branch from 6553d77 to 2dea9e2 Compare December 14, 2023 19:51
auto-merge was automatically disabled December 19, 2023 23:02

Merge queue setting changed

@jpayne3506 jpayne3506 enabled auto-merge December 21, 2023 00:19
@jpayne3506 jpayne3506 force-pushed the singhvipul/ciliumtimestamp branch from 2dea9e2 to cdee420 Compare December 21, 2023 00:19
@jpayne3506 jpayne3506 added this pull request to the merge queue Dec 21, 2023
@jpayne3506 jpayne3506 removed this pull request from the merge queue due to a manual request Dec 21, 2023
@jpayne3506 jpayne3506 added this pull request to the merge queue Dec 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 21, 2023
@vipul-21 vipul-21 added this pull request to the merge queue Dec 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 21, 2023
@vipul-21 vipul-21 added this pull request to the merge queue Dec 22, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 22, 2023
@jpayne3506 jpayne3506 added this pull request to the merge queue Dec 23, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 24, 2023
@vipul-21
ci: add date to cilium nightly cluster name
64b5b7b 
Signed-off-by: Vipul Singh <singhvipul@microsoft.com>
@vipul-21 vipul-21 force-pushed the singhvipul/ciliumtimestamp branch from cdee420 to 64b5b7b Compare December 27, 2023 15:28
@vipul-21 vipul-21 enabled auto-merge December 27, 2023 15:29
@vipul-21 vipul-21 added this pull request to the merge queue Dec 27, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 27, 2023
@jpayne3506 jpayne3506 added this pull request to the merge queue Jan 3, 2024
Merged via the queue into master with commit c086fba Jan 3, 2024
13 checks passed
@jpayne3506 jpayne3506 deleted the singhvipul/ciliumtimestamp branch January 3, 2024 23:05
matmerr pushed a commit that referenced this pull request Jan 17, 2024
@vipul-21 @matmerr
ci: add date to cilium nightly cluster name (#2425)
9231b30 
Signed-off-by: Vipul Singh <singhvipul@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpayne3506 jpayne3506 jpayne3506 approved these changes

@camrynl camrynl camrynl approved these changes

@debecerra debecerra Awaiting requested review from debecerra debecerra is a code owner automatically assigned from Azure/azure-sdn-members

Assignees
No one assigned
Labels
ci Infra or tooling.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vipul-21 @camrynl @jpayne3506